Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change namespace contains_nulls to struct #8523

Merged
merged 3 commits into from
Jun 16, 2021
Merged

Change namespace contains_nulls to struct #8523

merged 3 commits into from
Jun 16, 2021

Conversation

davidwendt
Copy link
Contributor

This PR just changes the contains_nulls namespace to be struct instead in order to remove it from the namespace list in the libcudf doxygen documentation.

namespace-list

Changing this to struct does not require any other code changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Jun 15, 2021
@davidwendt davidwendt self-assigned this Jun 15, 2021
@davidwendt davidwendt requested a review from a team as a code owner June 15, 2021 19:16
@codecov
Copy link

codecov bot commented Jun 16, 2021 •
edited
Loading

Codecov Report

Merging #8523 (2648284) into branch-21.08 (93ce6c7) will increase coverage by 0.40%.
The diff coverage is 100.00%.

❗ Current head 2648284 differs from pull request most recent head 76f4fb2. Consider uploading reports for the commit 76f4fb2 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.08    #8523      +/-   ##
================================================
+ Coverage         82.57%   82.98%   +0.40%     
================================================
  Files               109      109              
  Lines             17870    18197     +327     
================================================
+ Hits              14757    15100     +343     
+ Misses             3113     3097      -16
Impacted Files Coverage Δ
python/cudf/cudf/core/frame.py 93.41% <ø> (+0.45%) ⬆️
python/cudf/cudf/core/column/column.py 87.64% <100.00%> (+0.11%) ⬆️
python/cudf/cudf/core/dataframe.py 90.98% <100.00%> (+0.33%) ⬆️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/cudf/cudf/_fuzz_testing/io.py 0.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_csv.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ce6c7...76f4fb2. Read the comment docs.

@trxcllnt
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ca11a7f into rapidsai:branch-21.08 Jun 16, 2021
@davidwendt davidwendt deleted the contains-null-namespace branch June 17, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard robertmaynard approved these changes

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team doc Documentation libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @trxcllnt @robertmaynard